jaroheinonen/my-spotify-playlist-sorter-go
1
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Wiki Activity Actions

AddTracksToPlaylist panics when progress is omitted #20

New issue
Open
opened 2026-08-22 23:34:12 +03:00 by jaroheinonen · 0 comments
jaroheinonen commented 2026-08-22 23:34:12 +03:00
Owner
Copy link

The function accepts a ui.Progress interface and guards Start and Finish when it is nil, but calls progress.Advance unconditionally at internal/spotify/playlist.go#L136. A caller that omits progress receives a nil-interface panic after the first successful batch.

A Spotify-shaped test server returning a successful add-tracks response reproduced the panic with one track and progress == nil.

The function accepts a `ui.Progress` interface and guards `Start` and `Finish` when it is nil, but calls `progress.Advance` unconditionally at `internal/spotify/playlist.go#L136`. A caller that omits progress receives a nil-interface panic after the first successful batch. A Spotify-shaped test server returning a successful add-tracks response reproduced the panic with one track and `progress == nil`.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/github.com-urfave-cli-v2-3.x
bugs
No results found.
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jaroheinonen
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaroheinonen/my-spotify-playlist-sorter-go#20
No description provided.