jaroheinonen/my-spotify-playlist-sorter-go
1
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Automatic country detection commonly panics #16

New issue
Open
opened 2026-08-22 23:31:33 +03:00 by jaroheinonen · 0 comments
jaroheinonen commented 2026-08-22 23:31:33 +03:00
Owner
Copy link

GetDeviceCountry() treats the final component of an IANA timezone as a national capital. It then dereferences the country lookup result without checking for nil.

Timezones whose representative city is not a capital, such as America/New_York or America/Chicago, therefore panic. Both CLI and TUI flows use this function when the country field is omitted.

This was reproduced with time.Local set to America/New_York; GetByCapital("New_York") returned nil and the .Alpha2 access panicked.

`GetDeviceCountry()` treats the final component of an IANA timezone as a national capital. It then dereferences the country lookup result without checking for `nil`. Timezones whose representative city is not a capital, such as `America/New_York` or `America/Chicago`, therefore panic. Both CLI and TUI flows use this function when the country field is omitted. This was reproduced with `time.Local` set to `America/New_York`; `GetByCapital("New_York")` returned `nil` and the `.Alpha2` access panicked.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/github.com-urfave-cli-v2-3.x
bugs
No results found.
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jaroheinonen
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaroheinonen/my-spotify-playlist-sorter-go#16
No description provided.